Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for index_prefix #816

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Add support for index_prefix #816

merged 7 commits into from
Feb 6, 2025

Conversation

manav113
Copy link
Member

@manav113 manav113 commented Jan 29, 2025 •
edited
Loading

The PR adds support for index_prefixes mapping.

What's changed:

  1. Added a message for indexPrefixes which has min_chars and max_chars property
  2. Added PrefixFieldDef which is responsible for prefix indexing and searching.
  3. Added PrefixWrappedAnalyzer which wraps the EdgeNGramTokenFilter to generate the prefixes
  4. Changed TextFieldDef to incorporate the new field
  5. getPrefixQuery is changed to incorporate the prefix query search logic in case index_prefixes is used

@manav113 manav113 requested a review from aprudhomme January 29, 2025 20:58
aprudhomme
aprudhomme reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@aprudhomme aprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most the way there

clientlib/src/main/proto/yelp/nrtsearch/luceneserver.proto Outdated Show resolved Hide resolved
clientlib/src/main/proto/yelp/nrtsearch/luceneserver.proto Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/PrefixFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/PrefixFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/PrefixFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/TextFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/query/QueryNodeMapper.java Outdated Show resolved Hide resolved
src/test/java/com/yelp/nrtsearch/server/field/PrefixFieldDefTest.java Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/PrefixFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/PrefixFieldDef.java Show resolved Hide resolved
@manav113
Removing optional from proto file, adding some comments, refactoring …
2583771 
…prefixField to TextDefField, impleting PrefixQuery in ATOM field
@manav113 manav113 requested a review from aprudhomme February 3, 2025 07:52
@manav113 manav113 marked this pull request as ready for review February 3, 2025 07:52
aprudhomme
aprudhomme reviewed Feb 3, 2025
View reviewed changes
src/main/java/com/yelp/nrtsearch/server/analysis/PrefixWrappedAnalyzer.java Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/query/QueryNodeMapper.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/AtomFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/TextFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/TextFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/TextFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/TextFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/TextFieldDef.java Outdated Show resolved Hide resolved
src/main/java/com/yelp/nrtsearch/server/field/properties/PrefixQueryable.java Show resolved Hide resolved
@manav113 manav113 requested a review from aprudhomme February 3, 2025 23:33
aprudhomme
aprudhomme previously approved these changes Feb 4, 2025
View reviewed changes
@manav113
Fixed span prefix query to use the default logic by introducing a boo…
06d1822 
…lean field and added rewrite method for automaton query
@manav113 manav113 requested a review from aprudhomme February 5, 2025 20:00
@manav113 manav113 merged commit 49f16bc into main Feb 6, 2025
1 check passed
@manav113 manav113 deleted the patelmanav_add_index_prefixes_support branch February 6, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprudhomme aprudhomme aprudhomme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manav113 @aprudhomme