Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sidecar resource limit configurable #3647

Merged
merged 2 commits into from
Aug 3, 2023
Merged

make sidecar resource limit configurable #3647

merged 2 commits into from
Aug 3, 2023

Conversation

ajayOO8
Copy link
Contributor

@ajayOO8 ajayOO8 commented Jul 11, 2023

Currently the default limits/request of the hacheck, uwsgi containers is huge for a sidecar containers.
making these configuration configurable.
for now I have set the default limit as same as the current limit.

paasta_tools/kubernetes_tools.py Outdated Show resolved Hide resolved
paasta_tools/kubernetes_tools.py Show resolved Hide resolved
paasta_tools/utils.py Outdated Show resolved Hide resolved
@ajayOO8 ajayOO8 force-pushed the COMPINFRA-2833 branch 3 times, most recently from 23843d3 to 960f850 Compare July 18, 2023 12:45
@ajayOO8 ajayOO8 requested a review from nemacysts July 20, 2023 16:31
Copy link
Member

@nemacysts nemacysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, but you'll want to also update the callsite for where the gunicorn exporter gets its requirements :)

(it should behave pretty similarly to the uwsgi exporter)

paasta_tools/kubernetes_tools.py Outdated Show resolved Hide resolved
@ajayOO8 ajayOO8 merged commit adb2dd8 into master Aug 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants