Don't hard-code legacy yelpcorp PyPI registry, remove pip-custom-platform #3664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal ticket: CORESERV-12777
The general idea is to (1) remove pip-custom-platform, (2) stop hard-coding the PyPI registry URL in places where it's possible, and (3) hard-code the platformed registry at least if we have to.
We set the registry URL globally in
/etc/pip.conf
on Yelp hosts and inside Yelp's Docker images, so we should be able to get away with not specifying it in most locations. This also allows us to take advantage of the platform-specific registries which no longer need pip-custom-platform. Unfortunately it is not so easy to rely on this for many of the Docker images so I had to hard-code the platform-specific registry.Same idea as Yelp/Tron#921.
Passed locally on a yelpcorp host: