Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for SKJ on EKS - PAASTA-17987 #3696

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Adding support for SKJ on EKS - PAASTA-17987 #3696

merged 1 commit into from
Sep 11, 2023

Conversation

EmanElsaban
Copy link
Contributor

@EmanElsaban EmanElsaban commented Sep 7, 2023 •
edited
Loading

This PR adds the flag --eks which is used to add support for running SKJ with eks-*.yaml files.

Testing

Tested manually on the kind cluster (paasta playground) for eks-kind-emanelsabban-k8s-test.yaml file.
Output of updating an instance and creating one using skj: https://fluffy.yelpcorp.com/i/RqHGP7qXXp5WhKtm5GF9hXclNnK753GV.html


emanelsabban@dev208-uswest1adevc:~$ kubectl --context kind-emanelsabban-k8s-test --kubeconfig /nail/home/emanelsabban/pg/paasta/k8s_itests/kubeconfig get pods -A
NAMESPACE            NAME                                                              READY   STATUS    RESTARTS   AGE
eks-autoscaling      compute-infra-test-service-eks-autoscaling-6545db6bfb-66l2g       1/1     Running   0          11s
eks-autoscaling      compute-infra-test-service-eks-autoscaling-6545db6bfb-69855       1/1     Running   0          11s
eks-autoscaling      compute-infra-test-service-eks-autoscaling-6545db6bfb-klvwz       1/1     Running   0          11s
eks-autoscaling      compute-infra-test-service-eks-autoscaling-6545db6bfb-nspqh       1/1     Running   0          11s
eks-autoscaling      compute-infra-test-service-eks-autoscaling-6545db6bfb-wwp4v       1/1     Running   0          11s
kube-system          coredns-558bd4d5db-m2l76                                          1/1     Running   0          25h
kube-system          coredns-558bd4d5db-q746k                                          1/1     Running   0          25h
kube-system          etcd-emanelsabban-k8s-test-control-plane                          1/1     Running   0          25h
kube-system          kindnet-92l9p                                                     1/1     Running   0          25h
kube-system          kindnet-hnqb8                                                     1/1     Running   0          25h
kube-system          kindnet-rc2w2                                                     1/1     Running   0          25h
kube-system          kube-apiserver-emanelsabban-k8s-test-control-plane                1/1     Running   0          25h
kube-system          kube-controller-manager-emanelsabban-k8s-test-control-plane       1/1     Running   0          25h
kube-system          kube-proxy-2p8wn                                                  1/1     Running   0          25h
kube-system          kube-proxy-44wjr                                                  1/1     Running   0          25h
kube-system          kube-proxy-ckw2n                                                  1/1     Running   0          25h
kube-system          kube-scheduler-emanelsabban-k8s-test-control-plane                1/1     Running   0          25h
local-path-storage   local-path-provisioner-58c8ccd54c-58ncr                           1/1     Running   0          25h
new-instance-test    compute-infra-test-service-eks-new--instance--test-596b495wmrwb   1/1     Running   0          2m34s
new-instance-test    compute-infra-test-service-eks-new--instance--test-596b495xlf4h   1/1     Running   0          28s

nemacysts
nemacysts approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@nemacysts nemacysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i have a minor nit re: the argparse help text, but looks good otherwise!

paasta_tools/setup_kubernetes_job.py Outdated
@@ -88,6 +91,13 @@ def parse_args() -> argparse.Namespace:
type=int,
help="Update or create up to this number of service instances. Default is 0 (no limit).",
)
parser.add_argument(
"--eks",
help="This flag checks k8 services running on EKS",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help="This flag checks k8 services running on EKS",
help="This flag deploys only k8 services that should run on EKS",

@EmanElsaban EmanElsaban merged commit d41e709 into master Sep 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemacysts nemacysts nemacysts approved these changes

@EvanKrall EvanKrall Awaiting requested review from EvanKrall

@cuza cuza Awaiting requested review from cuza

@bobokun bobokun Awaiting requested review from bobokun

@KaspariK KaspariK Awaiting requested review from KaspariK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmanElsaban @nemacysts