Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTP application #1302

Merged
merged 27 commits into from
Dec 15, 2023
Merged

Add OTP application #1302

merged 27 commits into from
Dec 15, 2023

Conversation

elibon99
Copy link
Contributor

This PR mainly implements support for the OTP application. In addition, it also introduces a couple of UI changes related to input field validation.

Copy link
Member

@AdamVe AdamVe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/fido/views/reset_dialog.dart Outdated Show resolved Hide resolved
lib/fido/views/reset_dialog.dart Show resolved Hide resolved
lib/otp/features.dart Outdated Show resolved Hide resolved
lib/otp/views/configure_chalresp_dialog.dart Outdated Show resolved Hide resolved
lib/otp/views/configure_static_dialog.dart Outdated Show resolved Hide resolved
lib/otp/views/configure_yubiotp_dialog.dart Outdated Show resolved Hide resolved
lib/otp/views/configure_yubiotp_dialog.dart Outdated Show resolved Hide resolved
lib/otp/views/configure_yubiotp_dialog.dart Outdated Show resolved Hide resolved
lib/otp/views/configure_yubiotp_dialog.dart Outdated Show resolved Hide resolved
Copy link
Member

@AdamVe AdamVe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elibon99 elibon99 merged commit 624f4aa into main Dec 15, 2023
13 checks passed
@elibon99 elibon99 deleted the elias/yubiotp branch December 15, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants