Update nginx.conf to allow use in element web #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you running your own livekit and jwt ? |
|
@rosbeef Sorry, I'm not entirely sure what you are asking. If you want to configure your element web instance to use this element call instance, you should add the element_call config your element web's config.json file as specified here. Then make the changes to the nginx config as seen in this pull request. If you want to customise the turn server (and other external services?) used by element call, I can't help you with that sorry. |
ericgaspar
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to remove these lines from nginx to allow for element web to embed and use the custom instance.
It could be more securely implemented with an install option to ask for the element web domain, then setting that in
more_set_headers "Content-Security-Policy: frame-ancestors '__ELEMENT_WEB_DOMAIN__'";but I don't have the time to try do that :)(Might close #36 but not too sure what exactly they're asking)