Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh: support for not totally free packages #2055

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Enh: support for not totally free packages #2055

merged 11 commits into from
Feb 27, 2024

Conversation

OniriCorpe
Copy link
Member

@OniriCorpe OniriCorpe commented Feb 25, 2024 •
edited
Loading

  • rename not-totally-free to not-totally-free-upstream in antifeatures.toml
    • propagate this change to apps.toml
  • create not-totally-free-package in antifeatures.toml
  • description adjustment in antifeatures.toml
  • tag the only package i know who uses a "not totally free license" (GoToSocial_ynh) in apps.toml
  • add link to the package license in the store

with a link to the package license

this is missing in the webadmin for the moment, see YunoHost/yunohost-admin#545

@OniriCorpe OniriCorpe linked an issue Feb 25, 2024 that may be closed by this pull request
Warn user if a package uses a non-free / post-free licence YunoHost/issues#2341
Closed
1 task
@OniriCorpe OniriCorpe mentioned this pull request Feb 25, 2024
Merged
1 task
@OniriCorpe OniriCorpe self-assigned this Feb 27, 2024
alexAubin
alexAubin approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@alexAubin alexAubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but ugh there are conflicts on the .po/.mo

@OniriCorpe
Copy link
Member Author

LGTM but ugh there are conflicts on the .po/.mo

I was just solving that :"3

@OniriCorpe

This comment was marked as outdated.

Sign in to view
@OniriCorpe
Copy link
Member Author

done ^w^

@alexAubin alexAubin merged commit 863a6e2 into master Feb 27, 2024
2 checks passed
@ericgaspar ericgaspar deleted the not-totally-free-rework branch February 27, 2024 19:08
Salamandar pushed a commit that referenced this pull request Sep 13, 2024
@alexAubin
Merge pull request #2055 from YunoHost/not-totally-free-rework
48b1be5 
Enh: support for not totally free packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexAubin alexAubin alexAubin approved these changes

Assignees

@OniriCorpe OniriCorpe

Labels
pending
Projects
technical stuff
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn user if a package uses a non-free / post-free licence
2 participants
@OniriCorpe @alexAubin