Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helpers: Further simplify the change url helper #1746

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

Josue-T
Copy link
Contributor

@Josue-T Josue-T commented Nov 29, 2023

The problem

In change url script we need workaround like this because path and domain are the old one and so somethings are set with old values.

Solution

Set correctly the domain and path with new values.

PR Status

Patch on helper was tested here: https://github.com/YunoHost-Apps/seafile_ynh/blob/master/scripts/change_url#L27-L52

@alexAubin
Copy link
Member

I'm further simplifying the helper

The whole thing with the trick of "if only the domain change, we only mv the config" was supposedly design around the fact that the user may have manually modified the conf

Ironically, in this case we savagely overwrite the checksum, which means that next time ynh_add_nginx_config, the file will appear as not manually modified and be overwritten anyway

So let's reduce the complexity considering that this the current trick doesn't solve the problem anyway ...

@alexAubin alexAubin changed the title Fix change url helpers: Further simplify the change url helper Dec 5, 2023
@alexAubin alexAubin merged commit 857a285 into dev Dec 5, 2023
2 checks passed
@alexAubin alexAubin deleted the fix_change_url branch December 5, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants