provision: reload the firewall only once #1846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OniriCorpe
force-pushed
the
provision-reload-firewall-once
branch
from
16e6d99
to
dbeae78
Compare
OniriCorpe
force-pushed
the
provision-reload-firewall-once
branch
from
dbeae78
to
832b9d3
Compare
OniriCorpe
force-pushed
the
provision-reload-firewall-once
branch
from
d70f5ac
to
6b564ef
Compare
OniriCorpe
force-pushed
the
provision-reload-firewall-once
branch
from
455456b
to
b8b683b
Compare
Salamandar
approved these changes
May 21, 2024
alexAubin
reviewed
May 22, 2024
| logger.warning( | ||
| m18n.n("port_already_closed", port=port, ip_version=ipv) | ||
| ) | ||
| logger.warning(m18n.n("port_already_closed", port=port, ip_version=ipv)) |
There was a problem hiding this comment.
Ugh actually we probably want to have an option to disable this warning, otherwise everytime a port is not to be "exposed" (= the vast majority of the apps ?), yunohost will display a warning during install/upgrade/... when provision ports
Similar stuff for port_already_open too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
for now, during the provisionning/deprovisionning, the firewall is reloaded for each added or removed port
for example:
Solution
check if the port list has changed at the end of the port provisionning/deprovisionning, and if so: reload the firewall
PR Status
done
How to test
do a port provisionning/deprovisionning
not tested tho