-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to allow/disallow main email, email alias and email forward form portal #1997
base: dev
Are you sure you want to change the base?
Conversation
…orward form portal
On instances with a lot of users, the problem is that it's possible for a user to define alias like |
"allow_edit_email_alias": portal_allow_edit_email_alias, | ||
"allow_edit_email_forward":portal_allow_edit_email_forward | ||
}, sort_keys=True, indent=4 | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should already managed by ConfigPanel. It doesn't work without ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue currently is that we store 2 config at different places. One global setting which is not accessible by the portal API and an other one more specific to the portal api which is accessible by the portal api (and which is specific to the domain).
The issue currently is that to me this setting is expected to be global it don't really make sens to be different between 2 domain as it's also a security thing. So I added this parameters in the global setting. But this can't be read by the config panel. So it's why I added one global config for the portal API (sychromized from the global setting) so the portal api can read the config.
Co-authored-by: ljf (zamentur) <[email protected]>
PR related to: YunoHost/yunohost-portal#21
The problem
In Yunohost portal, user is always allowed to edit the mail alias and mail forward rule.
In some instance it could be a security issue to allow to edit by example the mail alias.
Solution
Add 3 new Yunohost settings to define if the user is allowed to edit
PR Status
Tested locally it work
How to test