Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring of YNH version. #2036

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Conversation

orhtej2
Copy link
Contributor

@orhtej2 orhtej2 commented Jan 22, 2025

The problem

Some apps require 12.x even though they should work on 11.x.
The idea is to merge this to dev then backport to bullseye.

Solution

Allow users to ignore required YNH version, even if it may break.

PR Status

To be tested.

How to test

Install Nextcloud 30.x on YNH 11.x

@yalh76
Copy link
Contributor

yalh76 commented Jan 22, 2025

I think, it would be a better idea to decrease the YunoHost version required on the package that still works on bullseye.

In the other hand, increaing the yunohost version required, reduce the work needed to maintain bullseye version and invite user to upgrade from bullseye to bookworm

@orhtej2
Copy link
Contributor Author

orhtej2 commented Jan 22, 2025

This is meant to be opt-in you're-on-your-own for people who are confident about what they're doing. I'm fully supporting 'you should move to 12.x' initiative.
This relies on #2034 getting merged in the first place, otherwise the point is moot.

@orhtej2
Copy link
Contributor Author

orhtej2 commented Jan 23, 2025

Works:

> sudo yunohost app upgrade fittrackee -i
Info: Now upgrading fittrackee…
Warning: This app requires YunoHost >= 12.0 but current installed version is 11.3.0.2

I was able to upgrade dendrite to 0.14.1 and nextcloud to 30.0.4 no problem after applying #2034 to bullseye server.

@orhtej2 orhtej2 marked this pull request as ready for review January 24, 2025 12:18
share/actionsmap.yml Outdated Show resolved Hide resolved
Co-authored-by: ljf (zamentur) <[email protected]>
src/app.py Outdated Show resolved Hide resolved
src/app.py Outdated Show resolved Hide resolved
alexAubin and others added 2 commits January 29, 2025 14:05
Co-authored-by: ljf (zamentur) <[email protected]>
Co-authored-by: ljf (zamentur) <[email protected]>
@zamentur zamentur merged commit 4e9d94c into YunoHost:dev Jan 29, 2025
3 checks passed
@orhtej2 orhtej2 deleted the ignore_ynh_version branch January 29, 2025 13:27
orhtej2 added a commit to orhtej2/yunohost that referenced this pull request Jan 30, 2025
* Allow ignoring of YNH version.

* typo

* Update share/actionsmap.yml

Co-authored-by: ljf (zamentur) <[email protected]>

* Update src/app.py

Co-authored-by: ljf (zamentur) <[email protected]>

* Update src/app.py

Co-authored-by: ljf (zamentur) <[email protected]>

---------

Co-authored-by: Alexandre Aubin <[email protected]>
Co-authored-by: ljf (zamentur) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants