Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFWEB 70 - On push strategy #12

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

KristofPeti
Copy link
Contributor

This pr will update the components to use the angular 16's on push change detection strategy.

Copy link
Collaborator

@ssaring ssaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me.

@manuel-mauky
Copy link
Collaborator

Any idea why the CI pipeline failed? I've done a re-run with debug info and it says

/usr/bin/git push origin gh-pages
  remote: Permission to ZEISS/angular-styleguide.git denied to github-actions[bot].
  fatal: unable to access 'https://github.com/ZEISS/angular-styleguide.git/': The requested URL returned error: 403

which is strange. There is nothing in this PR that changes the way the page is deployed to github pages.

@MariusAquarius
Copy link
Member

we are currently working on the CI pipeline and will investigate this issue

@MariusAquarius
Copy link
Member

The CI/CD pipeline should be fixed with the latest PR#16 .

@KristofPeti KristofPeti reopened this Jan 15, 2024
@manuel-mauky manuel-mauky merged commit 71fa130 into ZEISS:main Jan 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants