Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frost-client: add message confirmation step to Comms trait #491

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

conradoplg
Copy link
Contributor

Closes #476

I also did a small cleanup of passing SendSigningPackageArgs around instead of just SigningPackage since the former will actually have all the information the user needs to confirm what they're signing.

We don't address it exactly as suggested; rationale:

Since the tool is not aware of the protocol using it it's not possible to do the verification itself. However, it's important to show the user what they're signing and ask them if they really want to sign the message. We introduce that along with a trait method similar to what was suggested. In the context of Zcash, this will be amended later to show the transaction plan of the transaction being signed. At that point we will likely introduce some Content-Type data that will allow the user to understand what kind of data they are signing.

I've edited #333 to reflect some of these details.

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@natalieesk natalieesk merged commit 9965591 into main Feb 27, 2025
5 checks passed
@natalieesk natalieesk deleted the confirm-message-trait branch February 27, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion 1: Introduce Protocol-Specific Message Verification
2 participants