Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(log): Log a cute message for blocks that were mined by Zebra (off by default) #6098

Merged
merged 12 commits into from
Feb 23, 2023
Merged

change(log): Log a cute message for blocks that were mined by Zebra (off by default) #6098

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
85bc95c
Mark Zebra coinbase transactions with extra coinbase data
teor2345 Feb 3, 2023
57f49a9
Log when we commit a block mined by Zebra to our state
teor2345 Feb 3, 2023
6f08edd
Reduce logging instrumentation during block writes
teor2345 Feb 3, 2023
e109f55
Remove debug types in Zebra block log
teor2345 Feb 3, 2023
eb371bb
Add network and commit to write task logs
teor2345 Feb 3, 2023
7d9c11a
Apply an allow-list before we log arbitrary user messages from blocks
teor2345 Feb 10, 2023
02e67e0
Rate-limit Zebra mined block logging to once every 1000 blocks
teor2345 Feb 10, 2023
05fb4ed
Add mining configs for extra coinbase data and imitating zcashd, but …
teor2345 Feb 10, 2023
a6e78ea
Check CoinbaseData size limit when building transparent transactions
teor2345 Feb 10, 2023
75a0123
Replace LIKE_ZCASHD constants with a config
teor2345 Feb 10, 2023
fdf53ff
Take extra coinbase data from the configured string
teor2345 Feb 10, 2023
f85673c
Update the zebrad configs in the tests with new config fields
teor2345 Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions zebra-state/src/service/write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,13 +328,37 @@ fn log_if_mined_by_zebra(tip_block: &ChainTipBlock) {
.starts_with(EXTRA_ZEBRA_COINBASE_DATA.as_bytes())
{
let text = String::from_utf8_lossy(coinbase_data.as_ref());
let data = hex::encode(coinbase_data.as_ref());
info!(
?text,
?data,
%height,
%hash,
"looks like this block was mined by Zebra!"
);

if coinbase_data.as_ref() == EXTRA_ZEBRA_COINBASE_DATA.as_bytes() {
info!(
%text,
%height,
%hash,
"looks like this block was mined by Zebra!"
);
} else {
// # Security
//
// Use the extra data as an allow-list, replacing unknown characters.
// This makes sure control characters and harmful messages don't get logged
// to the terminal.
let text = text.replace(
|c| {
!EXTRA_ZEBRA_COINBASE_DATA
.to_ascii_lowercase()
.contains(c.to_ascii_lowercase())
},
"?",
);
let data = hex::encode(coinbase_data.as_ref());

info!(
%text,
%data,
%height,
%hash,
"looks like this block was mined by Zebra!"
);
}
}
}