Fix invalid parsing of INVERT expressions as CAT expressions #155

kindlich · 2024-06-09T09:51:18Z

The parser parsed ~i as UnaryExpression with OperatorType CAT instead of INVERT.

ToDos:

ScriptingEngineTester/src/main/resources/zencode_tests/expressions/int_operator_invert_2.zc is still broken because of type inference (see comments in file)
Implement the Builtins XXX_INVERT in the JavaMethodBytecodeCompiler.java for the other Primitive Types
Fix {FLOAT,DOUBLE}_INVERT -> They shouldn't have one
Some other Operators (e.g. NEG) are not implemented yet, should they be in this PR or on another one?

Closes #134

kindlich added 2 commits June 9, 2024 11:47

Fix invalid parsing of INVERT expressions as CAT expressions

0ea1c8e

Add tests for Invert operator on all primitive types

970dfe3

kindlich added bug Something isn't working bytecode All issues that relate to the generation of Java Bytecode parser labels Jun 10, 2024

kindlich added this to the Refactor milestone Jun 10, 2024

kindlich added 3 commits June 10, 2024 12:49

Floating Point types shouldn't have INVERT Operators

d286c52

Fix test names

af25abf

Fix negate operations

3fb759a

stanhebben approved these changes Jun 21, 2024

View reviewed changes

stanhebben merged commit f43ceef into feature/refactor Jun 21, 2024
0 of 2 checks passed

kindlich deleted the bugfix/134-int-doesnt-have-invert-operator branch June 21, 2024 20:01

Provide feedback