WIP: Started fixing check for incomplete implementations #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindlich
force-pushed
the
feature/refactor-incomplete-implementation
branch
from
4c34600 to
3a879eb
Compare
kindlich
commented
Sep 15, 2024
|
|
||
| @Override | ||
| public Void visitField(FieldMember member) { | ||
| validator.logError(member.position, CompileErrors.definitionNotAllowedHere("Field members not allowed inside an interface implementation")); |
There was a problem hiding this comment.
❓ Question: Which members are allowed inside an implementation?
Comment on lines
+115
to
+118
| return interfaceDefinition.members.stream() | ||
| .filter(IDefinitionMember::isAbstract) | ||
| .filter(o -> !implementedMethods.contains(o)) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
❓ Question: Are abstract classes allowed to partially implement an interface?
If so, this check would break.
Comment on lines
+25
to
+30
| this.interfaceDefinition = implementationMember.asImplementation() | ||
| .flatMap(TypeID::asDefinition) | ||
| .map(d -> d.definition) | ||
| .filter(InterfaceDefinition.class::isInstance) | ||
| .map(InterfaceDefinition.class::cast) | ||
| .orElseThrow(() -> new NoSuchElementException("Must be an implementation!")); |
There was a problem hiding this comment.
💭 Not the best way to go about this but at least we get the interfaceDefinition this way I guess?
Base automatically changed from
feature/refactor-capturing
to
feature/refactor-fix-more-tests
October 4, 2024 21:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #174
Also will most likely fail for abstract classes and the like 🤷🏽