-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Developer Tools #2734
base: master
Are you sure you want to change the base?
Create Developer Tools #2734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also probably add a feature to clear the response ?
The autistic part in me was also thinking about that, but then again you can just leave the screen and it will be reset. And other calls also always clear the response first. |
I think we have real estate in the top right corner for a clear button. It would be half the steps of leaving the page and returning. |
Yes, only question is, why would somebody want/need it? |
In the screenshot above you have a response that takes up the whole view. Instead of scrolling for some time to get back to the next response you want, you could simply have a button that resets the view. |
Or an icon to scroll to the top. I personally would like that better. Let me know what you prefer. |
Maybe we can have an icon on bottom right corner, that starts to be displayed if you scroll down... A click on that would scroll all the way to the top immediately. |
Looks perfect now! |
fb4333c
to
013f35c
Compare
(rebased) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True... What should we do? "No data"? |
Yeah something like No data found would be good I think |
This is after all, tools for devs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
No LND support yet? Just CLNRest and LNDHub? |
LND based backends all work and are therefore not even checked individually:
|
013f35c
to
5fb03cb
Compare
rebased/solved conflict |
Don't forget: You still might want to add a monospace font for iOS... |
Description
This fixes #117 by adding Developer Tools.
Added a monospace font for the response (Android only so far).
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: