Fix carousel width hight #1169
Merged
Fix carousel width hight #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🎊 PR Preview has been successfully built and deployed to https://zarm-preview-pr-1169.surge.sh
|
|
|
|
修改getOffsetSize方法，添加返回兜底数据，无报错 |
|
有问题哈，拖到最后一页就白屏了 |
|
简化方法使用，删除冗余的getOffsetSize |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1169 +/- ##
==========================================
+ Coverage 83.59% 90.40% +6.80%
==========================================
Files 17 220 +203
Lines 128 5127 +4999
Branches 21 1218 +1197
==========================================
+ Hits 107 4635 +4528
- Misses 21 482 +461
- Partials 0 10 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复Carousel组件宽高不精确问题。原offsetWidth offsetHeight计算不准确，在展示时内容会有像素偏差，下一个轮播内容会漏出一点。