Skip to content

Commit

Permalink
chore: allow to pass the base expiration height on zcashtools
Browse files Browse the repository at this point in the history
  • Loading branch information
emmanuelm41 committed Jan 23, 2025
1 parent 5478d85 commit 50bcb0a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions zcashtools/neon/lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ export var OUTPUT_PATH = resolve(__dirname, "..", "params/sapling-output.params"
export class ZcashBuilderBridge {
private readonly boxed: ZcashBuilder;

constructor(fee: number) {
this.boxed = addon.builderNew(fee)
constructor(fee: number, height: number) {
this.boxed = addon.builderNew(fee, height)
}

add_transparent_input(t_input: TransparentInputInfo) {
Expand Down
2 changes: 1 addition & 1 deletion zcashtools/neon/lib/native.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ interface NativeModule {

calculate_zip317_fee(n_tin: number, n_tout: number, n_sspend: number, n_sout: number): number

builderNew(fee: number): ZcashBuilder;
builderNew(fee: number, height: number): ZcashBuilder;

builderAddTransparentInput(this: ZcashBuilder, tin: TransparentInputInfo): boolean;
builderAddTransparentOutput(this: ZcashBuilder, tout: TransparentOutputInfo): boolean;
Expand Down
5 changes: 3 additions & 2 deletions zcashtools/neon/native/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,9 @@ impl ZcashBuilderBridge {
// Methods exposed to javascript
impl ZcashBuilderBridge {
fn js_create_builder(mut cx: FunctionContext) -> JsResult<BoxedBuilder> {
let f = cx.argument::<JsNumber>(0)?.value(&mut cx);
let zcashbuilder = txbuilder::Builder::new_with_fee(TestNetwork, 0, f as u64);
let fee = cx.argument::<JsNumber>(0)?.value(&mut cx);
let height = cx.argument::<JsNumber>(1)?.value(&mut cx);
let zcashbuilder = txbuilder::Builder::new_with_fee(TestNetwork, height as u32, fee as u64);
let zcashbuilder = AuthorisationStatus::Unauthorized(zcashbuilder);
let boxed_builder = RefCell::new(ZcashBuilderBridge { zcashbuilder });
Ok(cx.boxed(boxed_builder))
Expand Down

0 comments on commit 50bcb0a

Please sign in to comment.