-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add Cpu Usage % to header for standalone server #3840
Conversation
The reason I didn't implement this, although it is nice to have as part of the toolset, is that I WILL NOT add a 1 second pause to loading the UI, so the plan was to make sure the db Server object existed and got updated even for non-multi-server case. Also, beware, not all OS's have /proc. In fact, linux may not have /proc either. |
Instead of 1 sec. period uses AJAX update period.
I've updated the code.
For Windows, you can receive the download without any gaps. I can add some code. But can Zoneminder be installed on Windows?
I’m not ready to answer anything yet, I need to think.
I see that CpuUsagePercent is not updated for server, although CpuLoad is updated. |
OpenBSD is the prime example of not having /proc. In linux land a container or something might not have it. It is uncommon, but possible. Which is why I left the top parsing code in perl-side. The top parsing is not reliable though. I intend to change the parsing to perl regexps instead of bash awk, etc to see what the actual output is that fails. In terms of SERVER_ID, we can just use = 0 when not in multi-server mode. Code just needs a few tweaks to make that work. This is all work in progress. Might be better if you joined slack, or discord or something to discuss with me more to prevent overlap of effort. Or maybe even the discussion parts of github since you are already here. Or forums... |
Ok Isaac, I get it. |
I'll try communicate better. Too used to working alone around here. I'll likely merge this, but just be aware that my plan is for most of this nice work to be not needed as the values will be updated in background in the db. |
I understand your thoughts. |
I'm confused why we'd want CPU usage if we already have system load average? |
These are slightly different values. |
They are very different values. On many of my servers, the load can be 20 or more, but cpu usage is about 50%. There are lots of different reasons why processes might be waiting on service (which is what load is a measure of). |
Closed as a draft because... there is a more recent version #3843 |
After: