Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: in function "scaleToFit" do not take padding into account if the width is enough (skin.js) #4065

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

IgorA100
Copy link
Contributor

@IgorA100 IgorA100 commented Jun 4, 2024

No description provided.

@IgorA100 IgorA100 changed the title Fix: in function "scaleToFit" do not take padding into account if the… Fix: in function "scaleToFit" do not take padding into account if the width is enough (skin.js) Jun 4, 2024
@IgorA100
Copy link
Contributor Author

IgorA100 commented Jun 5, 2024

@connortechnology
Please check on different pages with Scale=Auto
In theory, it should get better, not worse.

If everything goes well on all pages, I will clean up the code from "///".

@connortechnology
Copy link
Member

Looks fine to me...

@IgorA100
Copy link
Contributor Author

IgorA100 commented Jun 6, 2024

Ok.
I'll clean the code up and report back.

@IgorA100 IgorA100 marked this pull request as ready for review June 6, 2024 15:10
@connortechnology connortechnology merged commit d29a60a into ZoneMinder:master Jun 7, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants