Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various MSVC compilation fixes #708

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Various MSVC compilation fixes #708

merged 1 commit into from
Oct 7, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Oct 6, 2024

Assortment of tweaks to support the arguments warnings=extra werror=yes dev_build=yes d3d12=yes in an MSVC context

Zylann
Zylann reviewed Oct 6, 2024
View reviewed changes
generators/graph/node_type_db.cpp Outdated Show resolved Hide resolved
meshers/transvoxel/transvoxel.cpp Outdated Show resolved Hide resolved
streams/sqlite/connection.cpp Outdated Show resolved Hide resolved
terrain/instancing/voxel_instance_generator.cpp Outdated Show resolved Hide resolved
thirdparty/fast_noise_2/src/FastSIMD/FastSIMD.cpp Outdated Show resolved Hide resolved
util/string/expression_parser.cpp Outdated Show resolved Hide resolved
@Repiteo Repiteo force-pushed the msvc-fixes branch 2 times, most recently from 0193e7d to fa69550 Compare October 6, 2024 20:11
@Zylann Zylann merged commit bd6efa8 into Zylann:master Oct 7, 2024
25 checks passed
@Zylann
Copy link
Owner

Zylann commented Oct 7, 2024

Thanks!

@Repiteo Repiteo deleted the msvc-fixes branch October 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zylann Zylann Zylann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Repiteo @Zylann