rework key attestation key comparison #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodh
requested changes
Aug 20, 2024
nodh
reviewed
Aug 23, 2024
| cause = AttException.Content.Android( | ||
| it, | ||
| AttestationValueException( | ||
| it, |
There was a problem hiding this comment.
Much better, but this still seems off, because not every parameter is using the parameter name, and it takes up 14 lines to create the result
nodh
reviewed
Aug 23, 2024
| if (CryptoPublicKey.fromJcaPublicKey(keyToBeAttested) == CryptoPublicKey.fromJcaPublicKey( | ||
| firstTry.attestationCertificate.publicKey | ||
| ) | ||
| ) KeyAttestation(keyToBeAttested, firstTry) |
There was a problem hiding this comment.
would also refactor this, because it's not clear what's compared to what, and the if block has no curly braces, but the else block does, although it's also only one statement
|
Proposing refactorings in 0223716, merge at your discretion |
nodh
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tlenz this should be interesting for you too