-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding seeds for testing and staging purposes: One map, several layers… #376
Open
ut
wants to merge
4
commits into
feature-api-optimization
Choose a base branch
from
ut/372-seeds
base: feature-api-optimization
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a5403c4
Adding seeds for testing and staging purposes: One map, several layer…
ut ea5f4a7
Merge branch 'main' into ut/372-seeds
ut 490954a
Merge branch 'main' into ut/372-seeds
ut 5d4e8b5
chore: add basemap to seeds and pretty format seeds json
birtona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Langer Nitpick vorraus:
Warum braucht es hier ein Modul mit einer Klasse, welche nur aus
self
Methoden besteht? Grundsätzlch sollten Module und Klassen in der von Rails vorgesehenen Ordnerstruktur abgelegt werden und das ist hier nicht der Fall.Hintergrund: Ihr arbeitet augenscheinlich noch mit dem
:classic
Loader aus Rails 5.1. Mit Rails 7 ist der nicht mehr verfügbar, dann gibts nur noch den wesentlich schnelleren (und strikteren) Zeitwerk Loader: https://guides.rubyonrails.org/v7.0/classic_to_zeitwerk_howto.htmlSolange die referenzierten Klassen in der Gleichen Datei sind wird sich auch Zeitwerk nicht daran verschlucken, aber es wird über unerwartete Namen in unerwarteten Dateien warnen. Und in diesem konkreten Fall kann man ja auch mit "normalen" Funktionen für das Seeding gut leben?