Fixed not been able to control ReadOnlyMode property using one-way data binding (#133) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta binding A control should always use SetCurrentValue to set the value of its own dependency properties to preserve value source.
|
Thank for your help and support 😊 |
|
Thanks for accepting the pull request. Are you planning on making a new NuGet release sometime soon? |
|
Yes is possible to make a new release of the Nuget package |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #133 that prevents ReadOnlyMode property from been controlled by one-way data binding.
There are however more issues with the same underlining problem that remain as they are.
The problem is that the editor is changing it's own its own dependency properties, which resets the value source configured by the user of the control.
Control should always use SetCurrentValue to set the value of its own dependency properties, since it changes the effective value of the property, but keeps existing triggers, data bindings, and styles.