fix: fix crash on empty inputhistory, update inputhistory accordingly

abenz1267 · Jul 11, 2024 · 86f000f · 86f000f
1 parent 17d0e96
commit 86f000f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/history/inputhistory.go b/history/inputhistory.go
@@ -9,7 +9,7 @@ import (
 
 type InputHistory []string
 
-func (h InputHistory) SaveToInputHistory(input string) {
+func (h InputHistory) SaveToInputHistory(input string) InputHistory {
 	i := slices.Index(h, input)
 
 	if i != -1 {
@@ -23,6 +23,8 @@ func (h InputHistory) SaveToInputHistory(input string) {
 	}
 
 	util.ToGob(&h, filepath.Join(util.CacheDir(), "inputhistory.gob"))
+
+	return h
 }
 
 func GetInputHistory() InputHistory {

diff --git a/ui/interactions.go b/ui/interactions.go
@@ -342,7 +342,7 @@ func handleSearchKeysPressed(val uint, code uint, modifier gdk.ModifierType) boo
 	case gdk.KEY_Down:
 		selectNext()
 	case gdk.KEY_Up:
-		if ui.selection.Selected() == 0 {
+		if ui.selection.Selected() == 0 && len(inputhstry) > 0 {
 			currentInput := ui.search.Text()
 
 			if currentInput != "" && !slices.Contains(inputhstry, currentInput) {
@@ -492,7 +492,7 @@ func activateItem(keepOpen, selectNext bool) {
 		hstry.Save(entry.Identifier(), strings.TrimSpace(ui.search.Text()))
 	}
 
-	inputhstry.SaveToInputHistory(ui.search.Text())
+	inputhstry = inputhstry.SaveToInputHistory(ui.search.Text())
 
 	err := cmd.Start()
 	if err != nil {