Merge pull request #448 from ably/combine-packages

refactor: combine react and core packages into one
ably · Jan 17, 2025 · 208c96b · 208c96b
2 parents 192eed9 + 9b704b0
commit 208c96b
Show file tree

Hide file tree

Showing 65 changed files with 15,460 additions and 10,774 deletions.
diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml
@@ -6,6 +6,9 @@ on:
     branches:
       - main
 
+env:
+  BASE_NODE_VERSION: 22
+
 jobs:
   audit:
     runs-on: ubuntu-latest
@@ -15,7 +18,7 @@ jobs:
           submodules: true
       - uses: actions/setup-node@v1
         with:
-          node-version: 20
+          node-version: ${{ env.BASE_NODE_VERSION }}
       - run: npm ci
       - run: npm audit --production
   format-check:
@@ -26,7 +29,7 @@ jobs:
           submodules: true
       - uses: actions/setup-node@v1
         with:
-          node-version: 20
+          node-version: ${{ env.BASE_NODE_VERSION }}
       - run: npm ci
       - run: npm run format:check
   lint:
@@ -37,7 +40,7 @@ jobs:
           submodules: true
       - uses: actions/setup-node@v1
         with:
-          node-version: 20
+          node-version: ${{ env.BASE_NODE_VERSION }}
       - run: npm ci
       - run: npm run lint
   test-typescript:
@@ -48,25 +51,29 @@ jobs:
           submodules: true
       - uses: actions/setup-node@v1
         with:
-          node-version: 20
+          node-version: ${{ env.BASE_NODE_VERSION }}
       - run: npm ci
       - run: npm run test:typescript
   test:
     runs-on: ubuntu-latest
     permissions:
       contents: read
       pull-requests: write
+    strategy:
+      matrix:
+        node-version: [18, 20, 22]
+    name: test node ${{ matrix.node-version }}
     steps:
       - uses: actions/checkout@v2
         with:
           submodules: true
       - uses: actions/setup-node@v1
         with:
-          node-version: 20
+          node-version: ${{ matrix.node-version }}
       - run: npm ci
       - run: npm run test
       - uses: davelosert/vitest-coverage-report-action@v2
-        if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'ably/ably-chat-js' && always()
+        if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'ably/ably-chat-js' && matrix.node-version == ${{ env.BASE_NODE_VERSION }} && always()
   build:
     runs-on: ubuntu-latest
     steps:
@@ -75,7 +82,7 @@ jobs:
           submodules: true
       - uses: actions/setup-node@v1
         with:
-          node-version: 20
+          node-version: ${{ env.BASE_NODE_VERSION }}
       - run: npm ci
       - run: npm run build
   demo-app:
@@ -86,7 +93,7 @@ jobs:
           submodules: true
       - uses: actions/setup-node@v1
         with:
-          node-version: 20
+          node-version: ${{ env.BASE_NODE_VERSION }}
       - name: npm ci (lib)
         run: npm ci
       - name: npm build (lib)

diff --git a/.tool-versions b/.tool-versions
@@ -1 +1 @@
-nodejs 20.10.0
+nodejs 22.13.0