Update test data with corrected action values #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
splindsay-92
changed the base branch from
main
to
chore/update-ably-package-version
Coverage Report
File CoverageNo changed files found. |
splindsay-92
changed the base branch from
chore/update-ably-package-version
to
main
splindsay-92
force-pushed
the
bugfix/add-missing-fields-to-helper-test-payload
branch
from
5ae43d2 to
d2591a0
Compare
splindsay-92
changed the base branch from
main
to
chore/update-ably-package-version
splindsay-92
force-pushed
the
bugfix/add-missing-fields-to-helper-test-payload
branch
from
d2591a0 to
3f767af
Compare
AndyTWF
reviewed
Jan 14, 2025
test/core/helpers.test.ts
Outdated
| @@ -9,10 +9,11 @@ import { DefaultReaction } from '../../src/core/reaction.js'; | |||
|
|
|||
| const TEST_ENVELOPED_MESSAGE = { | |||
| id: 'chat:6TP2sA:some-room:219f7afc614af7b:0', | |||
| serial: '01719948956834-000@108TeGZDQBderu97202638', | |||
There was a problem hiding this comment.
We should probably omit the serial here per the original test - it was because of the incorrect action that it wasn't parsing it
splindsay-92
force-pushed
the
bugfix/add-missing-fields-to-helper-test-payload
branch
from
3f767af to
bd44c26
Compare
Set the action to `message.create` since the enums have changed.
splindsay-92
force-pushed
the
bugfix/add-missing-fields-to-helper-test-payload
branch
from
bd44c26 to
8abbc1b
Compare
splindsay-92
changed the title
AndyTWF
approved these changes
Jan 14, 2025
A race condition happens when we unmount the `usePresence` hook. Typically, we expect the unmounting to trigger a leave event, action by the caller through the `leaveClient()` func. What happens instead is, we unmount the component, which triggers the detach process (as we are unmounting the ChatProvider too). The `leaveClient()` races against this and loses, so when it finally executes, the channel state is now `detaching` and the function returns an error. Replaced `TestProvider` with a reusable `Providers` component so the hook and providers can be controlled separately. Updated tests to rerender `Providers` with dynamic children for better control over component lifecycle.
…esence-test Bugfix: Fix race condition in usePresence test
splindsay-92
merged commit de558f4
into
chore/update-ably-package-version
9 checks passed
splindsay-92
deleted the
bugfix/add-missing-fields-to-helper-test-payload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serial and created at fields were added to the test data since ably-js does not infer these from the version field.