Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3642] A preview of an implementation of the location pushes. #1771

Merged
merged 37 commits into from
Jul 25, 2023
Merged

[SDK-3642] A preview of an implementation of the location pushes. #1771

merged 37 commits into from
Jul 25, 2023

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Jun 19, 2023 •
edited
Loading

Closes #1762

@github-actions github-actions bot temporarily deployed to staging/pull/1771/features June 19, 2023 16:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc June 19, 2023 16:36 Inactive
@maratal maratal marked this pull request as draft June 19, 2023 16:44
@maratal maratal mentioned this pull request Jun 19, 2023
Closed
@maratal maratal force-pushed the feature/location-push branch from bd4f8d8 to b7dad6a Compare June 19, 2023 19:02
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features June 19, 2023 19:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc June 19, 2023 19:08 Inactive
@maratal maratal marked this pull request as ready for review June 19, 2023 20:48
@lawrence-forooghian
Copy link
Collaborator

@maratal thanks for submitting this — I think the approach here makes sense (assuming you've agreed the REST API changes with the Realtime team). I think the next thing is to formalise this in the spec — are you happy to do that?

@github-actions github-actions bot temporarily deployed to staging/pull/1771/features June 29, 2023 16:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc June 29, 2023 17:02 Inactive
@maratal maratal force-pushed the feature/location-push branch from bc96263 to e257354 Compare July 2, 2023 14:13
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features July 2, 2023 14:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc July 2, 2023 14:18 Inactive
lawrence-forooghian
lawrence-forooghian reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm submitting an initial review so that you have some feedback to start addressing, given that there seems to be some time pressure around it. However, I'd still like to think about it in a bit more detail, which I'll try to do soon.

Source/include/Ably/ARTPush.h Outdated Show resolved Hide resolved
Source/include/Ably/ARTPush.h Outdated Show resolved Hide resolved
Source/ARTRest.m Outdated Show resolved Hide resolved
Source/include/Ably/ARTPush.h Outdated Show resolved Hide resolved
Source/include/Ably/ARTPush.h Outdated Show resolved Hide resolved
Source/include/Ably/ARTPush.h Outdated Show resolved Hide resolved
Source/include/Ably/ARTPush.h Show resolved Hide resolved
Source/ARTPushActivationStateMachine.m Outdated Show resolved Hide resolved
Test/Tests/PushTests.swift Outdated Show resolved Hide resolved
Test/Tests/PushActivationStateMachineTests.swift Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features July 12, 2023 18:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc July 12, 2023 18:46 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features July 12, 2023 23:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc July 13, 2023 00:02 Inactive
@maratal maratal force-pushed the feature/location-push branch from 928cf26 to 794e634 Compare July 19, 2023 16:11
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features July 19, 2023 16:11 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc July 19, 2023 16:16 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features July 19, 2023 22:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc July 19, 2023 22:33 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features July 19, 2023 23:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc July 19, 2023 23:08 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features July 20, 2023 00:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc July 20, 2023 00:12 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features July 20, 2023 13:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc July 20, 2023 13:56 Inactive
@lawrence-forooghian lawrence-forooghian mentioned this pull request Jul 20, 2023
Open
@github-actions github-actions bot temporarily deployed to staging/pull/1771/features July 23, 2023 23:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1771/jazzydoc July 23, 2023 23:23 Inactive
@maratal maratal merged commit 997d00c into main Jul 25, 2023
@maratal maratal deleted the feature/location-push branch July 25, 2023 16:39
@maratal maratal changed the title A preview of an implementation of the location pushes. [SDK-3642] A preview of an implementation of the location pushes. Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawrence-forooghian lawrence-forooghian lawrence-forooghian approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement location push functionality
2 participants
@maratal @lawrence-forooghian