-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump upload-artifact
version
#2011
Conversation
Jobs seem to be randomly failing now that it’s deprecated; e.g. [1] gave > Error: This request has been automatically failed because it uses a > deprecated version of `actions/upload-artifact: v3`. Learn more: > https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ [1] https://github.com/ably/ably-cocoa/actions/runs/12694870211/job/35385596818?pr=2010
WalkthroughThe pull request involves updating the GitHub Actions workflow configuration in the Changes
Possibly related issues
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/check-pod.yaml (1)
Line range hint
12-12
: Consider updating the checkout action version.The workflow is using an outdated version of
actions/checkout@v2
. Consider upgrading tov4
for improved performance and security.- - uses: actions/checkout@v2 + - uses: actions/checkout@v4For reference, see the checkout action changelog.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/check-pod.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: check (macOS, test_macOS)
- GitHub Check: check (tvOS, test_tvOS17_2)
- GitHub Check: check (iOS, test_iOS17_2)
- GitHub Check: build
- GitHub Check: check
- GitHub Check: check
🔇 Additional comments (1)
.github/workflows/check-pod.yaml (1)
55-55
: LGTM! Good upgrade to address the deprecated action.The update from
upload-artifact@v3
tov4
is necessary and will resolve the job failures caused by the deprecated version.
I suggest that we merge this one since the |
Jobs seem to be randomly failing now that it’s deprecated; e.g. this job gave
Summary by CodeRabbit