-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.2.37 Release #2016
v1.2.37 Release #2016
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 SwiftLint (0.57.0)Test/Tests/RealtimeClientConnectionTests.swift[ Test/Tests/RestClientTests.swift[ WalkthroughThis pull request represents a version update from 1.2.36 to 1.2.37 for the Ably Cocoa library. The primary change involves reverting a previous breaking change by moving the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
3-10
: LGTM! Clear and concise changelog entry.The changes are well documented and follow the standard changelog format.
Consider using markdown link syntax instead of bare URLs for better readability:
-**Full Changelog**: https://github.com/ably/ably-cocoa/compare/1.2.36...1.2.37 +[Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.36...1.2.37) -* Reverts a breaking change by moving `presence` back to `ARTRealtime` https://github.com/ably/ably-cocoa/pull/2015 +* Reverts a breaking change by moving `presence` back to `ARTRealtime` [#2015](https://github.com/ably/ably-cocoa/pull/2015)🧰 Tools
🪛 Markdownlint (0.37.0)
5-5: null
Bare URL used(MD034, no-bare-urls)
9-9: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
CHANGELOG.md
(1 hunks)README.md
(2 hunks)Scripts/jazzy.sh
(1 hunks)Source/ARTClientInformation.m
(1 hunks)Test/Tests/ARTDefaultTests.swift
(1 hunks)Test/Tests/ClientInformationTests.swift
(3 hunks)Test/Tests/RealtimeClientConnectionTests.swift
(1 hunks)Test/Tests/RestClientTests.swift
(1 hunks)Version.xcconfig
(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- Version.xcconfig
- Scripts/jazzy.sh
- Test/Tests/ARTDefaultTests.swift
- Test/Tests/RestClientTests.swift
- Source/ARTClientInformation.m
- Test/Tests/RealtimeClientConnectionTests.swift
- README.md
🧰 Additional context used
🪛 Markdownlint (0.37.0)
CHANGELOG.md
5-5: null
Bare URL used
(MD034, no-bare-urls)
9-9: null
Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: check (macOS, test_macOS)
- GitHub Check: check (tvOS, test_tvOS17_2)
- GitHub Check: build
- GitHub Check: check (iOS, test_iOS17_2)
- GitHub Check: check
- GitHub Check: check
🔇 Additional comments (4)
Test/Tests/ClientInformationTests.swift (4)
12-12
: LGTM! Version update is consistent.The version string update from "1.2.36" to "1.2.37" in the
testAgents
method aligns with the release version.
30-30
: LGTM! Version update is consistent.The version string update in the
testAgentIdentifierWithAdditionalAgents_withNilAdditionalAgents
method matches the release version.
45-45
: LGTM! Version update is consistent.The version string update in the
testAgentIdentifierWithAdditionalAgents_withNonNilAdditionalAgents
method is aligned with the release version.
Line range hint
1-53
: Verify version consistency across the codebase.Let's ensure the version number is consistently updated across all relevant files.
✅ Verification successful
Version 1.2.37 is consistently used across the codebase
The version number has been correctly updated in the source definition and all relevant test files. No instances of the old version remain.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining occurrences of the old version and verify consistency of the new version echo "Checking for any remaining occurrences of old version 1.2.36..." rg "1\.2\.36" --type-add 'swift:*.{swift,h,m}' --type swift echo -e "\nVerifying consistency of new version 1.2.37..." rg "1\.2\.37" --type-add 'swift:*.{swift,h,m}' --type swift echo -e "\nChecking version in package files..." fd -e podspec -e plist -x cat {}Length of output: 15971
Release PR for v1.2.37
Summary by CodeRabbit
Revert
presence
functionality back toARTRealtime
Version Update
Tests