Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: sdk issue form template #200

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions templates/sdk-github-issue-template.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Bug Report
description: File a bug report
title: "[Bug]: "
labels: ["bug", "triage"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against using the "triage" label but if we're gonna go for that we ought to add it to https://github.com/ably/engineering/blob/main/sdk/github.md#labels and document some process about how we use it - i guess that would just be "remove the label once the bug is prioritised"

body:
- type: input
id: library-version
attributes:
label: Library version
description: What version of the library are you using?
placeholder: ex. v1.2.21
validations:
required: true
# Can remove this field for most SDKs, but useful for JS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I think this wouldn't even be useful for JS (and certainly not for js v2 😄). I would suggest replacing this with a "Which platform are you experiencing this issue on" (runtime version, browser/react-native/nodejs, etc) which would probably be useful for every SDK.

- type: input
id: library-package
attributes:
label: Library package
description: What package are you using within the library?
placeholder: e.g. Callbacks, promises
validations:
required: true
- type: textarea
id: what-happened
attributes:
label: What happened?
description: What went wrong? Tell us what you see!
validations:
required: true
- type: textarea
id: expected-behaviour
attributes:
label: What did you expect to happen?
description: If things were working as you'd expect, what would have you seen instead?
validations:
required: true
- type: textarea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal preference would be to merge these two fields into an "additional information" field which suggests sharing a minimal repro or debug logs

id: reproduction
attributes:
label: Minimal reproduction code
description: It would be really helpful if you could provide us with some minimal code that reproduces the issue. Please make sure you remove any sensitive data such as your Ably API key(s)!
render: shell
- type: textarea
id: logs
attributes:
label: Log output
description: If possible, please provide us with verbose logs from the SDK related to the issue. Again, make sure you remove any sensitive data!
render: shell