-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support latest python versions #547
Conversation
sacOO7
commented
Jan 16, 2024
- Fixed Support for python 3.12 #546
f4cbaef
to
da827ac
Compare
Need to check for flake8 error when used with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve once the CI is passing, but just wanted to say: if linting across every python version is a problem then we should just move the flake8 step to its own workflow and run it on a single version of python - we don't really need to run it on every version.
I agree to this 👍 |
e0777af
to
31f83fb
Compare