Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest python versions #547

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Support latest python versions #547

merged 10 commits into from
Jan 18, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Jan 16, 2024

@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 16, 2024 14:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 17, 2024 08:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 17, 2024 09:21 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 17, 2024 09:40 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 17, 2024 09:57 Inactive
@sacOO7 sacOO7 force-pushed the feature/support-3.1x branch from f4cbaef to da827ac Compare January 17, 2024 10:01
@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 17, 2024 10:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 17, 2024 11:09 Inactive
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jan 17, 2024

Need to check for flake8 error when used with python-3.12

@sacOO7 sacOO7 requested review from owenpearson and ttypic January 17, 2024 11:20
@sacOO7 sacOO7 marked this pull request as ready for review January 17, 2024 11:20
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

.github/workflows/check.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 17, 2024 13:08 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 17, 2024 13:21 Inactive
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve once the CI is passing, but just wanted to say: if linting across every python version is a problem then we should just move the flake8 step to its own workflow and run it on a single version of python - we don't really need to run it on every version.

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jan 18, 2024

I'll approve once the CI is passing, but just wanted to say: if linting across every python version is a problem then we should just move the flake8 step to its own workflow and run it on a single version of python - we don't really need to run it on every version.

I agree to this 👍

@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 18, 2024 06:38 Inactive
@sacOO7 sacOO7 force-pushed the feature/support-3.1x branch from e0777af to 31f83fb Compare January 18, 2024 06:39
@github-actions github-actions bot temporarily deployed to staging/pull/547/features January 18, 2024 06:40 Inactive
@sacOO7 sacOO7 merged commit 1a99f00 into main Jan 18, 2024
8 checks passed
@sacOO7 sacOO7 deleted the feature/support-3.1x branch January 18, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support for python 3.12
3 participants