Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-4082] Full nav redesign #2376

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

Conversation

jamiehenson
Copy link
Member

@jamiehenson jamiehenson commented Jan 13, 2025

Description

A mega PR to house the various overhauls of the navigation UI, and the underlying data structures (mainly represented in LeftSidebar, RightSidebar, Header, Footer and within src/data.

The majority of the work (up to here) has already been reviewed via the following PRs:

Everything from that point is specific to this PR.

Review

https://ably-docs-next-staging.herokuapp.com/

Copy link

coderabbitai bot commented Jan 13, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ably-ci ably-ci temporarily deployed to ably-docs-web-4082-docs-ol1yfp January 13, 2025 16:16 Inactive
@jamiehenson jamiehenson force-pushed the web-4082-docs-nav-redesign branch from f09fc47 to d3ef252 Compare January 13, 2025 16:39
@jamiehenson jamiehenson temporarily deployed to ably-docs-web-4082-docs-ol1yfp January 13, 2025 16:39 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 13, 2025 16:39 Inactive
@jamiehenson jamiehenson force-pushed the web-4082-docs-nav-redesign branch from d3ef252 to 1b979c6 Compare January 13, 2025 16:48
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 13, 2025 16:49 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-web-4082-docs-ol1yfp January 13, 2025 16:49 Inactive
@jamiehenson jamiehenson force-pushed the web-4082-docs-nav-redesign branch from 1b979c6 to a66396f Compare January 13, 2025 17:04
@jamiehenson jamiehenson temporarily deployed to ably-docs-web-4082-docs-ol1yfp January 13, 2025 17:04 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 13, 2025 17:04 Inactive
@m-hulbert m-hulbert temporarily deployed to ably-docs-web-4082-docs-ol1yfp January 14, 2025 13:16 Inactive
@kennethkalmer kennethkalmer temporarily deployed to ably-docs-next-staging January 14, 2025 13:16 Inactive
@kennethkalmer kennethkalmer temporarily deployed to ably-docs-next-staging January 15, 2025 12:18 Inactive
@m-hulbert m-hulbert temporarily deployed to ably-docs-web-4082-docs-ol1yfp January 15, 2025 12:18 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 15, 2025 17:13 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-web-4082-docs-ol1yfp January 15, 2025 17:13 Inactive
@jamiehenson jamiehenson force-pushed the web-4082-docs-nav-redesign branch from 318d56f to bb08d1a Compare January 16, 2025 14:56
@jamiehenson jamiehenson temporarily deployed to ably-docs-web-4082-docs-ol1yfp January 16, 2025 14:56 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 16, 2025 14:56 Inactive
@jamiehenson jamiehenson force-pushed the web-4082-docs-nav-redesign branch from bb08d1a to f3cf6b0 Compare January 16, 2025 15:10
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 16, 2025 15:11 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-web-4082-docs-ol1yfp January 16, 2025 15:11 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 27, 2025 15:52 Inactive
@jamiehenson jamiehenson force-pushed the web-4082-docs-nav-redesign branch from ae03e3a to 6a0b281 Compare January 27, 2025 16:13
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 27, 2025 16:14 Inactive
@jamiehenson jamiehenson force-pushed the web-4082-docs-nav-redesign branch from 6a0b281 to b070df5 Compare January 27, 2025 16:19
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 27, 2025 16:20 Inactive
@jamiehenson jamiehenson force-pushed the web-4082-docs-nav-redesign branch from b070df5 to 46d68c3 Compare January 27, 2025 16:27
@jamiehenson jamiehenson temporarily deployed to ably-docs-next-staging January 27, 2025 16:27 Inactive
@jamiehenson jamiehenson had a problem deploying to ably-docs-next-staging January 28, 2025 14:15 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants