Update package assembly to consider other manifests #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyanSinhaMahapatra
force-pushed
the
update-package-assembly
branch
from
b69f20e
to
3128b33
Compare
Previously we used to yeild resources for the entire subtree after we find a package manifest, and ingore and skip creating package and dependencies from other manifests present there. The package assembly process is updated to only yeild and ignore package manifest resources used already to create package/dependencies. Reference: #3604 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
update-package-assembly
branch
from
3128b33
to
eb5903b
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used to yeild resources for the entire subtree after we find a package manifest, and ingore and skip creating package and dependencies from other manifests present there. The package assembly process is updated to only yeild and ignore package manifest resources used already to create package/dependencies.
Reference: #3604
Tasks
Run tests locally to check for errors.