Add extension to allow bazelmod style handling of dependencies #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mering
approved these changes
Dec 20, 2024
mering
reviewed
Jan 7, 2025
mering
reviewed
Jan 7, 2025
mering
reviewed
Jan 7, 2025
helm/extensions.bzl
Outdated
| tag_classes = {"options": options}, | ||
| tag_classes = { | ||
| "options": options, | ||
| "import_repository": tag_class(attrs = { |
There was a problem hiding this comment.
Maybe call this chart such that helm.chart(...) imports a chart. As this is used in MODULE.bazel I can't imagine anything other than importing from a repository to make sense. All other ways to import charts are probably specified via BUILD files.
There was a problem hiding this comment.
NAK
I value the consistency with the documented functions in the Readme.md over isolated potentially better name.
In context, it's also obvious that this is rather: "import from repository" than "import a repository", as there's also a "helm_import" function.
mering
reviewed
Jan 7, 2025
Ongy
force-pushed
the
add-import-repository-extension
branch
from
0572050 to
eebaf6d
Compare
mering
reviewed
Jan 8, 2025
mering
reviewed
Jan 8, 2025
Ongy
force-pushed
the
add-import-repository-extension
branch
from
0124e8d to
988121b
Compare
|
@abrisco can you take a look at the naming discussion, and do another pass over the code? thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.