Fixed memory leak

[aburrell]

Description

There was a memory leak due to a lack of freeing PyObject pointers in the C code. Fixes #74 and #75 by clarifying the existing logger message.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Make sure to re-install AACGMV2 before testing, since the C code has to be re-compiled. Also added two new unit tests that would have segfaulted previously.

import timeit

# Yields 15.579 s on my system
timeit.timeit("import aacgmv2; import datetime; import numpy as np; rando_lat = np.random.uniform(low=-90,high=90,size=6000); rando_long = np.random.uniform(low=-180,high=180,size=6000);aacgmv2.convert_latlon_arr(rando_lat, rando_long, 350.0, datetime.datetime(2015, 5, 5), method_code='G2A')", number=1000)

# Yields 1866.4816 on my system
timeit.timeit("import aacgmv2; import datetime; import numpy as np; rando_lat = np.random.uniform(low=-90,high=90,size=6000); rando_long = np.random.uniform(low=-180,high=180,size=6000);aacgmv2.get_aacgm_coord_arr(rando_lat, rando_long, 350.0, datetime.datetime(2015, 5, 5), method='G2A')", number=1000)

# Yields x s on my system
timeit.timeit("import aacgmv2; import datetime; import numpy as np; rando_lon = np.random.uniform(low=-180,high=180,size=6000);aacgmv2.convert_mlt(rando_lon, datetime.datetime(2015, 5, 5), m2a=False)")

Test Configuration:

• Operating system: OS X Big Sur
• Version number: Python 3.9
• Any details about your local setup that are relevant

Checklist:

• Make sure you are merging into the develop (not main) branch
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• Add a note to Changelog.rst, summarising the changes
• Add yourself to AUTHORS.rst

[aburrell]

The code occasionally segfaults (regularly in tests). Trying to figure out why.

[coveralls]

Pull Request Test Coverage Report for Build 3998919162

• 70 of 74 (94.59%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.5%) to 92.655%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
aacgmv2/tests/test_py_aacgmv2.py	47	48	97.92%
aacgmv2/tests/test_c_aacgmv2.py	21	24	87.5%

Totals
Change from base Build 3972015180:	0.5%
Covered Lines:	1122
Relevant Lines:	1199

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 3998919162

• 70 of 74 (94.59%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.4%) to 92.58%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
aacgmv2/tests/test_py_aacgmv2.py	47	48	97.92%
aacgmv2/tests/test_c_aacgmv2.py	21	24	87.5%

Totals
Change from base Build 3972015180:	0.4%
Covered Lines:	1152
Relevant Lines:	1231

---

💛 - Coveralls

[aburrell]

@dinsmoro would you mind testing this branch?

[dinsmoro]

This branch fixes the memory leak issue! Thanks for solving it!