-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wardrobe - New Addon - System to modify wearables #10606
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Newlines at end of files
Co-authored-by: Mike-MF <[email protected]>
Since there appeared to be more items which needed some sort of config adjustment, might as well merge these into the normal compats as well
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Mike-MF <[email protected]>
Co-authored-by: Mike-MF <[email protected]>
Co-authored-by: Mike-MF <[email protected]>
Co-authored-by: Mike-MF <[email protected]>
Big undertaking, and a bit of a nitpick, but I feel like this'd be more maintainable if wardrobe entries were kept in a CfgWardrobe root entry:
Don't have to worry about inheritance, and easier for other components to hook into. Child classes could be a problem, though, but I don't think we'd want child classes to inherit their parent's variants anyway. |
WIP
When merged this pull request will:
Introduces a new system to modify currently worn gear.
For Example:
UX:
Compats for: GM, SOG, WS, RF
To Do:
- Rework the sound part to work with thesound_timing
property.- Rework the System to work with thecomponents[]
property.-- Defines the components of an Items. For example: Dustglasses.If it changes from an item with components to an item without the same components, it will deposit these components into the players inventory or vis versa, when changing to an item that requiers an component which the currently worn doesnt have, it needs to be in the inventory and will be removed when changed into.
-- Check for components is done, just need to return/remove components from/to the inventory.- Fix the formating of the configs so the checks dont fail?- Add more compats for the cdlc/vanilla stuff utilizing the component feature. (example: blk balaclava -> blk balaclava with eye protectors)- Find better default sounds- Do the Documentation thingyBugs:
- RF Altin Helmets: Seems like the helmet without any visor can be modified into a visor-version.Looks like it inherits wardrobe data?
IMPORTANT
⌚ If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
❓ Development Guidelines are read, understood and applied.
✔️ Title of this PR uses our standard template
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.