Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heist Scene Hero #11

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Heist Scene Hero #11

merged 8 commits into from
Dec 9, 2024

Conversation

angela139
Copy link
Collaborator

Info

Closes #10.

Adds landing section with information on the hackathon and link to interest form

Changes

  • Added package to load svg with diamond guys properly
  • Added title and info section with heist scene image

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Screenshot 2024-12-05 at 2 47 55 PM
Screenshot 2024-12-05 at 2 48 53 PM

@angela139 angela139 requested a review from serrachow as a code owner December 5, 2024 22:49
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diamondhacks-teaser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 5:44pm

next.config.js Show resolved Hide resolved
src/components/LandingText/style.module.scss Show resolved Hide resolved
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good

some visual nitpicks below but you dont have to address them if you dont want to

src/components/LandingText/index.tsx Outdated Show resolved Hide resolved
public/assets/heistscene.svg Show resolved Hide resolved
src/components/LandingText/style.module.scss Outdated Show resolved Hide resolved
@alexzhang1618
Copy link
Contributor

Hopped on the branch to update for Sean's comments, and refactored the hero so screen resizing looks better / more consistent with the rest of the content.

Screen.Recording.2024-12-09.at.9.42.12.AM.mov

@alexzhang1618 alexzhang1618 merged commit 23531ac into main Dec 9, 2024
4 checks passed
@alexzhang1618 alexzhang1618 deleted the feature/hero branch December 9, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants