Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cards translucent #64

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Make cards translucent #64

merged 2 commits into from
Jan 10, 2025

Conversation

SheepTester
Copy link
Member

@SheepTester SheepTester commented Jan 10, 2025

Info

There's no issue for this but it's bothered me a bit that the cards are grey while the background is dark bluish. On the figma the background was dark grey because it didn't have any of the Diamondhacks theming.

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

made cards translucent

Changes

  • changed $card-bg and $card-stroke to translucent white colors
  • login card has a background blur because of the binary decal in the back
  • updated the dashboard hero image to be transparent (I previously could not because on Figma they used a blend mode for the light thing, but I changed it to just a translucent white. doesn't look too different)

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

image

image

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackathon-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 9:00am

Copy link

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

Copy link
Collaborator

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to me to me

@SheepTester SheepTester merged commit 4429709 into main Jan 10, 2025
5 checks passed
@SheepTester SheepTester deleted the sean/translucent-cards branch January 10, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants