-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show github-annotation format #164
Conversation
@goatwu1993 thanks for this! Can you paste a few example outputs in the PR description? |
@aconrad I have updated the description. Not sure if that's what you wanted though. I opened a repo and a PR for testing/demo usage. PR: https://github.com/goatwu1993/pycobertura-test/pull/4/files p.s: Big thanks to this repo. I use it on a daily basis for work projects. |
This is great, thanks! Could you write a paragraph in the README about this feature? Explain how it works with examples, screenshots, and how to submit the generated report to Github? Can you also add a note under CHANGES file under the |
@aconrad would you prefer
|
The second works better for the long term. It's more explicit/self-explanatory. Thanks for asking! |
072e470
to
bc756e3
Compare
bf5f105
to
ae89c89
Compare
@aconrad ready for review again |
Co-authored-by: Alexandre Conrad-Dormoy <[email protected]>
Co-authored-by: Alexandre Conrad-Dormoy <[email protected]>
The PR looks great, @goatwu1993! I left a comment about the annotation error level being too intrusive. I could either go with a less intrusive level message or make it required so it puts the annotation level decision on the user. |
Co-authored-by: Alexandre Conrad-Dormoy <[email protected]>
bba8849
to
1ddf370
Compare
@aconrad Should I implement the options in CLI as well? |
I was just looking over that actually. Yeah, we should be able to pass options via the CLI.
But I'm also wondering how to make options specific to an argument. |
hmm, need more time to read some click document... |
We might just need to accept all options regardless of the format, sift through them, and direct the expected ones to the formatters. |
Thanks. I'm not sure I understand. Are you saying that the options |
no. I'm just saying these options may be not specific to GitHub Annotation reporter. There are numerous log format and some may take use of these options as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this PR, much appreciated!
Released in v3.1.0 |
Implement GitHub Anntation format
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-notice-message
motivation: use this package in GitHub action and warn uncovered code
command: