-
Notifications
You must be signed in to change notification settings - Fork 100
Add support for runtime classes on Acorn computeclasses #2363
Add support for runtime classes on Acorn computeclasses #2363
Conversation
c7ba8a4
to
f7cd45f
Compare
@cloudnautique can you give a practicall example here? I understand this is related to the kata POC. But can you:
|
@@ -125,6 +132,21 @@ func PriorityClassName(req router.Request, computeClass *adminv1.ProjectComputeC | |||
return computeClass.PriorityClassName, nil | |||
} | |||
|
|||
// RuntimeClassName checks that a defined RuntimeClass exists and returns the name of it | |||
func RuntimeClassName(req router.Request, computeClass *adminv1.ProjectComputeClassInstance) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are exporting this function. I don't think it is used outside this package. If that's true, can you unexport (lowercase) it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you were copying the pattern of PriorityClassName. If the same is true for that one, please unexport it as well
Runtime classes are added as in internal value on Acorn compute class objects. This allows for using things like Kata Containers. Signed-off-by: Bill Maxwell <[email protected]>
f7cd45f
to
1a1e7fa
Compare
Signed-off-by: Bill Maxwell <[email protected]>
@cjellick I added an update to the docs, which shows a project compute class YAML. I think that satisfies the compute class yaml request. Please let me know if it doesn't and I can update the docs some more. The field is set to the string name of a k8s
The RuntimeClass is set as a field on a K8s pod spec, when this is specified on the compute class a deployment will have it set like:
|
If the field is an empty string or unset, we should return a nil pointer. Signed-off-by: Bill Maxwell <[email protected]>
Signed-off-by: Bill Maxwell <[email protected]>
a391d5d
to
f4aade4
Compare
Runtime classes are added as in internal value on Acorn compute class objects. This allows for using things like Kata Containers.