Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Ignore auth failures when trying to pull apps during cli login #2366

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Ignore auth failures when trying to pull apps during cli login #2366

merged 1 commit into from
Dec 4, 2023

Conversation

keyallis
Copy link
Contributor

This has been causing failures in e2e

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@g-linville
Copy link
Contributor

I'm a bit confused; why are we getting auth failures in the first place?

@keyallis
Copy link
Contributor Author

If we are logged in as a user that doesn't have permissions to pull apps in a given project and then we try to log in as another user. What we're seeing in e2e is that when we log in as a non-permissioned user for rbac tests and then try to log back in as the default e2e user we fail to pull app information and then never actually log in because the cli never attempts to do the auth login flow once we fail to pull apps

@g-linville
Copy link
Contributor

Why does logging in try to pull app information?

@keyallis
Copy link
Contributor Author

keyallis commented Dec 1, 2023

That would be a question for @ibuildthecloud

@keyallis keyallis merged commit ea6b20a into acorn-io:main Dec 4, 2023
3 of 4 checks passed
@keyallis keyallis deleted the e2e-login-fix branch December 4, 2023 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants