This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Ensure that nginx does DNS lookups #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
commented
Dec 5, 2023
When using static hostnames, nginx will lookup the DNS for these hostnames on startup/config reload and won't do it again until the container is restarted or the config is reloaded. This means that if the service IPs change, then nginx won't have the correct IPs until one of these things happen. This change uses a hack to ensure that nginx will look up for the DNS for services at least every 15 seconds. This ensures that if the service IPs change for some reason, then nginx will get them. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
no-nginx-cache-ips
branch
from
c842cd2 to
874834d
Compare
thedadams
requested review from
njhale,
StrongMonkey,
keyallis,
g-linville,
tylerslaton and
iwilltry42
g-linville
approved these changes
Dec 5, 2023
iwilltry42
approved these changes
Dec 5, 2023
|
In which case, service IP could change and that would require nginx to look up again? |
|
@StrongMonkey A change like this one where the linked services are changing. |
StrongMonkey
approved these changes
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using static hostnames, nginx will lookup the DNS for these hostnames on startup/config reload and won't do it again until the container is restarted or the config is reloaded. This means that if the service IPs change, then nginx won't have the correct IPs until one of these things happen.
This change uses a hack to ensure that nginx will look up for the DNS for services at least every 15 seconds. This ensures that if the service IPs change for some reason, then nginx will get them.