Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Add support to ignore resource requests/limits for local dev purposes #2400

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Add support to ignore resource requests/limits for local dev purposes #2400

merged 3 commits into from
Jan 9, 2024

Conversation

keyallis
Copy link
Contributor

@keyallis keyallis commented Jan 8, 2024

Without flag set:

12:15:45 ~/acorns/mine/nginx (local) % a run -n app -m 1Gi . ; a ps -o yaml | yq '.items[0].status.scheduling'
... (app build/deploy output)
nginx:
  requirements:
    limits:
      memory: 1Gi
    requests:
      memory: 1Gi
  tolerations:
    - key: taints.acorn.io/workload
      operator: Exists

With flag set:

12:17:45 ~/acorns/mine/nginx (local) % a run -n app -m 1Gi . ; a ps -o yaml | yq '.items[0].status.scheduling'
... (app build/deploy output)
nginx:
  requirements: {}
  tolerations:
    - key: taints.acorn.io/workload
      operator: Exists

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Signed-off-by: Oscar Ward <[email protected]>
Copy link
Contributor

@tylerslaton tylerslaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad to see this get in.

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@cjellick cjellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the name of the flag to be changed (see commented) and I'd like to see tests added

@keyallis keyallis requested a review from cjellick January 9, 2024 06:16
@keyallis keyallis merged commit e533da1 into acorn-io:main Jan 9, 2024
5 checks passed
@keyallis keyallis deleted the ignore-resource-requests branch January 9, 2024 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants