This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
fix: remove resolvedOfferings, defaults, and scheduling for containers not defined in app #2468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered this bug earlier today while working on something else. If you do
acorn update --image <image> <app name>
, and containers that were previously defined in the app no longer are, the resolved offerings, defaults, and scheduling information would still be present in the app's status for the old containers, even though they are not in the app anymore. This PR adds logic to delete containers from these maps when they no longer exist in the app. I also added new unit tests that check for this.Checklist
This is a title (#1216)
. Here's an example