Fix #75: phpcompatibility/php-compatibility dev-develop

[danepowell]

Motivation

Fixes #75

Proposed changes

Update phpcompatibility/php-compatibility to dev-develop branch, as recommended by its maintainers (can switch back to stable after a 10.0 release)

Rohit was right, phpcompatibility 9.x does basically nothing when running in a PHP 8 environment. Case in point: Acquia CLI, which uses a ton of PHP 8 syntax, never saw a violation from this standard on 9.x. Updating to the develop branch revealed thousands of violations.

We should consider this a breaking change. If we release it, projects that don't want to support PHP 7 will need to change the minimum version in their phpcs.xml:

• Update minimum PHP version for PHPCompatibility sniff to 7.4 #37
• CLI-1413: Set PHP compatibility level cli#1807

Projects that do support PHP 7 may still expect to see some violations.

Alternatives considered

• Drop this project and replace it with a phpstan equivalent
• Drop this project and do nothing. That would be functionally equivalent to the present situation.

Testing steps

Try this on projects of various PHP versions

[TravisCarden]

Tests pass. Works for me. ¯\_(ツ)_/¯

[joshirohit100]

Looks fine! I will try this