Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run one simulation at a time #109

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Run one simulation at a time #109

merged 4 commits into from
Apr 9, 2024

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Apr 2, 2024

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

  • Clean up how we construct new objects
  • add support for leases

Testing done

  • make test
  • tests added for the lease objects

Additional info

Resolves #58

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 92.77778% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 74.39%. Comparing base (c4f4259) to head (a9ceddf).

Files Patch % Lines
ctrl/controller.rs 56.25% 7 Missing ⚠️
driver/main.rs 0.00% 2 Missing ⚠️
driver/runner.rs 83.33% 2 Missing ⚠️
cli/snapshot.rs 0.00% 1 Missing ⚠️
ctrl/cert_manager.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   73.38%   74.39%   +1.00%     
==========================================
  Files          36       37       +1     
  Lines        1924     2023      +99     
==========================================
+ Hits         1412     1505      +93     
- Misses        512      518       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmorr0
Copy link
Contributor Author

drmorr0 commented Apr 2, 2024

Kubernetes Object DAG

%%{init: {'themeVariables': {'mainBkg': '#ddd'}}}%%
graph LR

classDef default color:#000
subgraph global
  direction LR
  global/simkube[<b>Namespace</b><br>simkube]
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-tracer
  direction LR
  simkube/sk-tracer-svc[<b>Service</b><br>sk-tracer-svc]
  simkube/sk-tracer-depl[<b>Deployment</b><br>sk-tracer-depl]
  simkube/sk-tracer-sa[<b>ServiceAccount</b><br>sk-tracer-sa]
  sk-tracer/sk-tracer-crb[<b>ClusterRoleBinding</b><br>sk-tracer-crb]
  simkube/sk-tracer-tracer-config[<b>ConfigMap</b><br>sk-tracer-tracer-config]
  simkube/sk-tracer-sa--->simkube/sk-tracer-depl
  sk-tracer/sk-tracer-crb--->simkube/sk-tracer-depl
  simkube/sk-tracer-tracer-config--->simkube/sk-tracer-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-ctrl
  direction LR
  simkube/sk-ctrl-depl[<b>Deployment</b><br>sk-ctrl-depl]
  simkube/sk-ctrl-sa[<b>ServiceAccount</b><br>sk-ctrl-sa]
  sk-ctrl/sk-ctrl-crb[<b>ClusterRoleBinding</b><br>sk-ctrl-crb]
  simkube/sk-ctrl-sa--->simkube/sk-ctrl-depl
  sk-ctrl/sk-ctrl-crb--->simkube/sk-ctrl-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph test
  direction LR
  simkube/test-depl[<b>Deployment</b><br>test-depl]
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

global--->sk-tracer
global--->sk-ctrl
global--->test

%% STYLE DEFINITIONS START
  style simkube/sk-ctrl-depl fill:#cb4
%% STYLE DEFINITIONS END
Loading

New object
Deleted object
Updated object
Updated object (causes pod recreation)

Detailed Diff

simkube/sk-ctrl-depl: ChangedWithPodRecreate

root['spec']['template']['spec']['containers'][0]['env'][2]['name']:
"POD_OWNER" --> "CTRL_NAMESPACE"
root['spec']['template']['spec']['containers'][0]['env'][3]:
not present --> {
  "name": "POD_OWNER",
  "value": "sk-ctrl-depl"
}
root['spec']['template']['spec']['containers'][0]['env'][2]['value']:
"sk-ctrl-depl" --> not present
root['spec']['template']['spec']['containers'][0]['env'][2]['valueFrom']:
not present --> {
  "fieldRef": {
    "fieldPath": "metadata.namespace"
  }
}

@drmorr0 drmorr0 changed the title clean up object metadata code Run one simulation at a time Apr 9, 2024
@drmorr0 drmorr0 merged commit 4ebc0d4 into master Apr 9, 2024
10 checks passed
@drmorr0 drmorr0 deleted the drmorr/lease branch April 9, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict to one simulation at a time
1 participant