Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor into workspaces #124

Merged
merged 4 commits into from
Jul 17, 2024
Merged

refactor into workspaces #124

merged 4 commits into from
Jul 17, 2024

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Jul 16, 2024

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

Starts using workspaces for the "compilation speed"

Testing done

  • make test still passes

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 79.01235% with 17 lines in your changes missing coverage. Please review.

Project coverage is 74.43%. Comparing base (c8ecc41) to head (be74bde).

Files Patch % Lines
sk-core/src/k8s/sim.rs 0.00% 7 Missing ⚠️
sk-core/src/time.rs 57.14% 3 Missing ⚠️
sk-ctrl/src/errors.rs 0.00% 3 Missing ⚠️
sk-ctrl/src/cert_manager.rs 0.00% 1 Missing ⚠️
sk-ctrl/src/controller.rs 75.00% 1 Missing ⚠️
sk-store/src/watchers/dyn_obj_watcher.rs 0.00% 1 Missing ⚠️
sk-store/src/watchers/pod_watcher.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   72.15%   74.43%   +2.27%     
==========================================
  Files          40       44       +4     
  Lines        2313     2546     +233     
==========================================
+ Hits         1669     1895     +226     
- Misses        644      651       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmorr0 drmorr0 force-pushed the drmorr/cargo-workspaces branch 4 times, most recently from 01ddb21 to f42059a Compare July 17, 2024 19:47
@drmorr0 drmorr0 force-pushed the drmorr/cargo-workspaces branch from f42059a to be74bde Compare July 17, 2024 19:49
@drmorr0 drmorr0 changed the title [WIP] refactor into workspaces refactor into workspaces Jul 17, 2024
@drmorr0 drmorr0 merged commit 8d83174 into master Jul 17, 2024
8 checks passed
@drmorr0 drmorr0 deleted the drmorr/cargo-workspaces branch July 17, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant