Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle local paths without file:/// #142

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Oct 4, 2024

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

Local path resolution in the driver and skctl no longer requires the file:/// prefix

Testing done

  • Manual testing
  • new tests added

@drmorr0 drmorr0 force-pushed the drmorr/fix-local-path-resolution branch from 0df53db to 01611d6 Compare October 4, 2024 06:27
@drmorr0 drmorr0 force-pushed the drmorr/fix-local-path-resolution branch from 01611d6 to 7c4f13a Compare October 4, 2024 06:27
@drmorr0 drmorr0 merged commit bdd05b7 into master Oct 4, 2024
6 checks passed
@drmorr0 drmorr0 deleted the drmorr/fix-local-path-resolution branch October 4, 2024 06:31
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (059b1e0) to head (7c4f13a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files          49       49           
  Lines        2723     2723           
=======================================
  Hits         1971     1971           
  Misses        752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant